Skip to content

Conversation

@rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Apr 10, 2019

Ⅰ. Describe what this PR did

remove comment line

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

NO

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang [email protected]

remove comment line

Signed-off-by: Rudy Zhang <[email protected]>
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

❗ No coverage uploaded for pull request head (volume@d8286db). Click here to learn what that means.
The diff coverage is n/a.

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Apr 10, 2019
@allencloud
Copy link
Collaborator

CI fails:

FILE: ./docs/api/HTTP_API.md
[✖] https://tools.ietf.org/html/4632

ERROR: dead links found!

I think it is flaky. Merging...

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Apr 10, 2019
@allencloud allencloud merged commit 5d78d4a into AliyunContainerService:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants