Skip to content

Conversation

@wangforthinker
Copy link
Contributor

Signed-off-by: allen.wang [email protected]

Ⅰ. Describe what this PR did

Support to update memory swap by cri.

Ⅱ. Does this pull request fix one issue?

none.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add unit test.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #2781 into master will increase coverage by 0.7%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2781     +/-   ##
=========================================
+ Coverage   68.64%   69.34%   +0.7%     
=========================================
  Files         277      277             
  Lines       17425    17431      +6     
=========================================
+ Hits        11961    12088    +127     
+ Misses       4108     4012     -96     
+ Partials     1356     1331     -25
Flag Coverage Δ
#criv1alpha2_test 39.35% <22.22%> (-0.03%) ⬇️
#integration_test_0 36.54% <0%> (+0.04%) ⬆️
#integration_test_1 35.75% <0%> (+0.01%) ⬆️
#integration_test_2 36.45% <0%> (-0.05%) ⬇️
#integration_test_3 35.56% <0%> (?)
#node_e2e_test 35.21% <11.11%> (-0.12%) ⬇️
#unittest 28.54% <55.55%> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri.go 71.48% <33.33%> (-0.67%) ⬇️
cri/v1alpha2/cri_utils.go 88.12% <83.33%> (+0.31%) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/spec_linux.go 78.77% <0%> (ø) ⬆️
daemon/mgr/image.go 59.45% <0%> (+0.54%) ⬆️
apis/server/router.go 91.35% <0%> (+0.61%) ⬆️
daemon/mgr/container_stats.go 71.83% <0%> (+1.14%) ⬆️
ctrd/client.go 69.39% <0%> (+1.63%) ⬆️
registry/auth.go 55.14% <0%> (+1.86%) ⬆️
... and 14 more

@zhuangqh
Copy link
Contributor

TODO: create a test in https://github.com/alibaba/cri-tools

Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhuangqh zhuangqh merged commit d814407 into AliyunContainerService:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants