-
Notifications
You must be signed in to change notification settings - Fork 944
cri: remove v1alpha1 codebase #2765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2765 +/- ##
========================================
+ Coverage 69.39% 69.5% +0.1%
========================================
Files 277 277
Lines 17435 17401 -34
========================================
- Hits 12099 12094 -5
+ Misses 4008 3977 -31
- Partials 1328 1330 +2
|
|
please also remove cri alphav1 related code here |
|
sorry for the late reply. please take a look. If it is good to go, we can move it on. |
|
I would like to invite @zhuangqh to review and merge if reasonable. |
Signed-off-by: Wei Fu <[email protected]>
zhuangqh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Wei Fu [email protected]
Ⅰ. Describe what this PR did
time to remove v1alpha1 cri
Ⅱ. Does this pull request fix one issue?
fix #2689
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
none
Ⅳ. Describe how to verify it
CI
Ⅴ. Special notes for reviews