Skip to content

Conversation

@fuweid
Copy link
Contributor

@fuweid fuweid commented Mar 19, 2019

Signed-off-by: Wei Fu [email protected]

Ⅰ. Describe what this PR did

The rich-mode container depends on the systemd to start the stopped
process automatically. But it might take more time to starting. 60s
might be too long but just in case that the system environment might
impact the process.

Ⅱ. Does this pull request fix one issue?

none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

CI

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #2761 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
- Coverage   69.42%   69.32%   -0.11%     
==========================================
  Files         277      277              
  Lines       17412    17412              
==========================================
- Hits        12089    12070      -19     
- Misses       4002     4018      +16     
- Partials     1321     1324       +3
Flag Coverage Δ
#criv1alpha2_test 39.38% <ø> (-0.03%) ⬇️
#integration_test_0 36.59% <ø> (+0.01%) ⬆️
#integration_test_1 35.81% <ø> (ø) ⬆️
#integration_test_2 36.5% <ø> (ø) ⬆️
#integration_test_3 35.55% <ø> (+0.1%) ⬆️
#node_e2e_test 35.18% <ø> (-0.13%) ⬇️
#unittest 28.51% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 58.82% <0%> (-11.77%) ⬇️
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
apis/server/utils.go 71.15% <0%> (-3.85%) ⬇️
pkg/meta/store.go 67.44% <0%> (-1.56%) ⬇️
cri/v1alpha2/cri.go 71.5% <0%> (-0.65%) ⬇️
daemon/mgr/container_utils.go 82.38% <0%> (-0.57%) ⬇️
ctrd/container.go 55.83% <0%> (-0.39%) ⬇️
ctrd/client.go 69.39% <0%> (+1.63%) ⬆️
daemon/mgr/events.go 91.78% <0%> (+2.73%) ⬆️

The rich-mode container depends on the systemd to start the stopped
process automatically. But it might take more time to starting. 60s
might be too long but just in case that the system environment might
impact the process.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid changed the title test: increase waiting time for daemon releated test test: increase waiting time for daemon related test Mar 19, 2019
@HusterWan
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Mar 19, 2019
@HusterWan HusterWan merged commit fec1739 into AliyunContainerService:master Mar 19, 2019
@fuweid fuweid deleted the me-increase-wait-time branch March 19, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants