Skip to content

Conversation

@fengzixu
Copy link
Contributor

Signed-off-by: fengzixu [email protected]

Ⅰ. Describe what this PR did

  1. revise the binary path of pouchd
  2. delete the systemctl enable pouch

Ⅱ. Does this pull request fix one issue?

#2610

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Just the script.

Ⅳ. Describe how to verify it

I found the clearing the VM and installed the Ubuntu. The info of the operating system as below:

Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.5 LTS
Release:	16.04
Codename:	xenial
root@xr-service-mesh-lab

Then I run scripts called allinone_aliyun.sh and allinone.sh. It can created the Kubernetes cluster which pouch container engine for me.

root@xr-service-mesh-lab:/home/root/workspace/go-project/src/github.com/alibaba/pouch/hack/kubernetes# kubectl get pods
NAME                    READY     STATUS    RESTARTS   AGE
nginx-db897d5d4-l6h2v   1/1       Running   0          19m
nginx-db897d5d4-wdkmz   1/1       Running   0          19m
root@xr-service-mesh-lab:/home/root/workspace/go-project/src/github.com/alibaba/pouch/hack/kubernetes#

Ⅴ. Special notes for reviews

I just revise the script which was processed in Ubuntu.

bugfix: repair the script of creating k8s cluster with pouch

1. revise the binary path of pouchd
2. delete the `systemctl enable pouch`

Related to: AliyunContainerService#2610

This is my final commit for pouch in 2018. Thanks for pouch.
Happy New Year!
@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #2632 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2632      +/-   ##
==========================================
+ Coverage    69.5%   69.56%   +0.05%     
==========================================
  Files         280      280              
  Lines       18844    18844              
==========================================
+ Hits        13098    13109      +11     
+ Misses       4279     4264      -15     
- Partials     1467     1471       +4
Flag Coverage Δ
#criv1alpha1test 31.23% <ø> (-0.13%) ⬇️
#criv1alpha2test 35.61% <ø> (-0.06%) ⬇️
#integrationtest 41.71% <ø> (+0.03%) ⬆️
#nodee2etest 32.72% <ø> (+0.02%) ⬆️
#unittest 26.91% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha1/cri.go 59.43% <0%> (-0.34%) ⬇️
cri/v1alpha2/cri.go 67.57% <0%> (-0.25%) ⬇️
cri/v1alpha2/cri_wrapper.go 65.59% <0%> (ø) ⬆️
ctrd/container.go 59.28% <0%> (+0.39%) ⬆️
ctrd/image.go 78.18% <0%> (+2.27%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️
pkg/streams/utils.go 89.28% <0%> (+7.14%) ⬆️

@pouchrobot pouchrobot added kind/bug This is bug report for project os/ubuntu size/S labels Dec 28, 2018
@fengzixu
Copy link
Contributor Author

@fuweid Please review it.

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 2a033d0 into AliyunContainerService:master Dec 28, 2018
@fengzixu
Copy link
Contributor Author

Thanks for everyone. This is my final commit in 2018 for pouch. Happy New Year! See you 2019.

@allencloud
Copy link
Collaborator

See you 2019.

So good to have you in 2018. Wish you a happy new year. And wish we could have more technical communication in 2019. @fengzixu

@fuweid
Copy link
Contributor

fuweid commented Dec 28, 2018

@fengzixu Thanks!
see you in 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project os/ubuntu size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants