feature: support get security options in daemon #2408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2408 +/- ##
==========================================
+ Coverage 68.39% 68.46% +0.06%
==========================================
Files 275 275
Lines 18278 18291 +13
==========================================
+ Hits 12502 12523 +21
+ Misses 4348 4341 -7
+ Partials 1428 1427 -1
|
show daemon security options, include four part, seccomp, apparmor, selinux and userns. Signed-off-by: Ace-Tang <[email protected]>
Contributor
|
link #2116 |
Contributor
Author
|
Thanks for @fuweid , but the pr not link to the issue, I will created the PR to fix the issue soon. |
fuweid
reviewed
Nov 2, 2018
Contributor
|
basically, LGTM. But we need to add blank line between different package group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show daemon security options, include four part,
seccomp, apparmor, selinux and userns.
Signed-off-by: Ace-Tang [email protected]
Ⅰ. Describe what this PR did
support security information showed by pouch info , show daemon security options, include four part,
seccomp, apparmor, selinux and userns.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews