Skip to content

ci: output log when install criu #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018
Merged

ci: output log when install criu #2323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hack/install/install_criu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ main() {
os_dist="$(detect_os)"
if [[ "${os_dist}" = "Ubuntu" ]]; then
Copy link
Contributor

@fuweid fuweid Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add one comment here?

Copy link
Contributor Author

@Ace-Tang Ace-Tang Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so, >>>> install criu <<<< will tell begin to download dependencies. and >>>> start to download criu from github repository <<<< will tell begin to download from github. Then we can know which step stack.

criu::ubuntu::install_dependencies > /dev/null
echo ">>>> start to download criu from github repository <<<<"
Copy link
Collaborator

@allencloud allencloud Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the downloading task fails, would this script show the detailed reason why it fails? @Ace-Tang

Copy link
Contributor

@fuweid fuweid Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes.

Copy link
Contributor Author

@Ace-Tang Ace-Tang Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only know we stack at downing from github.

Copy link
Collaborator

@allencloud allencloud Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then it meets my demand.

criu::ubuntu::install > /dev/null
else
echo "will support redhat soon"
Expand Down