Skip to content

Conversation

@zhuangqh
Copy link
Contributor

Signed-off-by: codejuan [email protected]

Ⅰ. Describe what this PR did

add pouch metrics and related test

  • ContainerActionsCounter
  • ContainerSuccessActionsCounter
  • ImageActionsCounter
  • ImageSuccessActionsCounter
  • ContainerActionsTimer
  • ImageActionsTimer

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cherry-pick

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #2303 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
+ Coverage   66.61%   66.84%   +0.22%     
==========================================
  Files         211      211              
  Lines       17195    17296     +101     
==========================================
+ Hits        11455    11562     +107     
+ Misses       4337     4328       -9     
- Partials     1403     1406       +3
Flag Coverage Δ
#criv1alpha1test 32.05% <42.57%> (+0.06%) ⬆️
#criv1alpha2test 35.6% <42.57%> (-0.06%) ⬇️
#integrationtest 40.09% <100%> (+0.5%) ⬆️
#nodee2etest 32.99% <42.57%> (-0.03%) ⬇️
#unittest 23.41% <6.89%> (-0.07%) ⬇️
Impacted Files Coverage Δ
apis/metrics/metrics.go 100% <100%> (ø) ⬆️
apis/server/container_bridge.go 83.84% <100%> (+2.77%) ⬆️
apis/server/image_bridge.go 72.72% <100%> (+2.72%) ⬆️
ctrd/image.go 76.75% <0%> (-2.2%) ⬇️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
cri/v1alpha2/cri_wrapper.go 61.2% <0%> (-1.2%) ⬇️
cri/v1alpha2/cri.go 66.03% <0%> (-0.59%) ⬇️
ctrd/container.go 57.85% <0%> (-0.48%) ⬇️
daemon/mgr/container.go 57.23% <0%> (+0.2%) ⬆️
daemon/containerio/container_io.go 75.95% <0%> (+1.09%) ⬆️
... and 3 more

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhuangqh zhuangqh force-pushed the feature-pouch-metric branch from 5aa7359 to 4c129f6 Compare October 10, 2018 07:41
@HusterWan
Copy link
Contributor

Since this pr has been reviewed very careful, so LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Oct 11, 2018
Copy link
Contributor

@CodeJuan CodeJuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HusterWan HusterWan merged commit 149b75e into AliyunContainerService:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants