bugfix: fix error api json #2225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2225 +/- ##
=========================================
- Coverage 66.57% 61.88% -4.7%
=========================================
Files 208 208
Lines 16744 16744
=========================================
- Hits 11148 10362 -786
- Misses 4273 5197 +924
+ Partials 1323 1185 -138
|
HusterWan
reviewed
Sep 11, 2018
| // > nondistributable artifacts. | ||
| // | ||
| AllowNondistributableArtifactsCIDRs []string `json:"AllowNondistributableArtifactsCIDRs"` | ||
| AllowNondistributableArtifactsCIDRs []string `json:"AllowNondistributableArtifactsCIDRs,omitempty"` |
Contributor
There was a problem hiding this comment.
changed again and again ...
rudyfly
changed the title
Modify missing `omitempty` in json for api Signed-off-by: Rudy Zhang <[email protected]>
rudyfly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Modify missing
omitemptyin json for api, genarate api by our swagger tool.We use swagger-0.12.0, and cherry-pick commit: b6e18f
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
NONE
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Signed-off-by: Rudy Zhang [email protected]