Skip to content

test: add unit-test for toCriSandbox #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

test: add unit-test for toCriSandbox #2002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 86 additions & 1 deletion cri/v1alpha1/cri_utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,92 @@ func Test_toCriSandbox(t *testing.T) {
want *runtime.PodSandbox
wantErr bool
}{
// TODO: Add test cases.
{
name: "normal test",
args: args{
c: &mgr.Container{
ID: "fakeID",
State: &apitypes.ContainerState{Status: apitypes.StatusRunning},
Name: "k8s_fakeID_fakeSandbox_ns_uid_7",
Config: &apitypes.ContainerConfig{Labels: map[string]string{
containerTypeLabelKey: "internal_type",
"annotation.ann": "ann",
"testLabel": "test",
}},
Created: "2018-07-30T19:05:06.000Z",
},
},
want: &runtime.PodSandbox{
Id: "fakeID",
Metadata: &runtime.PodSandboxMetadata{
Name: "fakeSandbox",
Namespace: "ns",
Uid: "uid",
Attempt: 7,
},
State: runtime.PodSandboxState_SANDBOX_READY,
CreatedAt: 1532977506000000000,
Labels: map[string]string{"testLabel": "test"},
Annotations: map[string]string{"ann": "ann"},
},
wantErr: false,
},
{
name: "illegal part num test",
args: args{
c: &mgr.Container{
ID: "fakeID",
State: &apitypes.ContainerState{Status: apitypes.StatusRunning},
Name: "fake_fakeSandbox_ns_uid_7",
Config: &apitypes.ContainerConfig{Labels: map[string]string{}},
Created: "2018-07-30T19:05:06.000Z",
},
},
want: nil,
wantErr: true,
},
{
name: "illegal prefix test",
args: args{
c: &mgr.Container{
ID: "fakeID",
State: &apitypes.ContainerState{Status: apitypes.StatusRunning},
Name: "pouch_fakeID_fakeSandbox_ns_uid_7",
Config: &apitypes.ContainerConfig{Labels: map[string]string{}},
Created: "2018-07-30T19:05:06.000Z",
},
},
want: nil,
wantErr: true,
},
{
name: "illegal format test",
args: args{
c: &mgr.Container{
ID: "fakeID",
State: &apitypes.ContainerState{Status: apitypes.StatusRunning},
Name: "k8s_fakeID_fakeSandbox_ns_uid_ss",
Config: &apitypes.ContainerConfig{Labels: map[string]string{}},
Created: "2018-07-30T19:05:06.000Z",
},
},
want: nil,
wantErr: true,
},
{
name: "illegal timestamp test",
args: args{
c: &mgr.Container{
ID: "fakeID",
State: &apitypes.ContainerState{Status: apitypes.StatusRunning},
Name: "k8s_fakeID_fakeSandbox_ns_uid_7",
Config: &apitypes.ContainerConfig{Labels: map[string]string{}},
Created: "2018-07-3019:05:06.000Z",
},
},
want: nil,
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down