Skip to content

bugfix: pouch pull should handle space input as an error #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2018
Merged

bugfix: pouch pull should handle space input as an error #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cli/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,11 @@ func pullMissingImage(ctx context.Context, apiClient client.CommonAPIClient, ima
}
}

namedRef, _ := reference.Parse(image)
namedRef, err := reference.Parse(image)
if err != nil {
return err
}

namedRef = reference.TrimTagForDigest(reference.WithDefaultTagIfMissing(namedRef))

var name, tag string
Expand Down
5 changes: 5 additions & 0 deletions pkg/reference/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ func TestParse(t *testing.T) {
tag: "1669a6aa7350e1cdd28f972ddad5aceba2912f589f19a090ac",
},
err: nil,
}, {
name: "Contains space input",
input: " ",
expected: nil,
err: ErrInvalid,
},
} {
ref, err := Parse(tc.input)
Expand Down