-
Notifications
You must be signed in to change notification settings - Fork 943
doc: Modify the document about Kubernetes&pouch to make it friendly #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4094cb7 to
f2d89e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
- Coverage 40.49% 37.23% -3.26%
==========================================
Files 254 254
Lines 16533 17665 +1132
==========================================
- Hits 6695 6578 -117
- Misses 8975 10237 +1262
+ Partials 863 850 -13
|
d81badc to
6452b7a
Compare
Collaborator
|
I think here we have a flaky test which is related to log, @fuweid : |
ZouRui89
reviewed
Jun 4, 2018
hack/kubernetes/allinone.sh
Outdated
| KUBERNETES_VERSION_UBUNTU="1.9.4-00" | ||
| KUBERNETES_VERSION_CENTOS="1.9.4" | ||
| echo "----------------------------------" | ||
| echo "Please choose the version of kubernetes" |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a extra colon?
echo "Please choose the version of kubernetes" -> echo "Please choose the version of kubernetes:"
505766a to
24f6a9d
Compare
Signed-off-by: Starnop <[email protected]>
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Modify the document about
Deploy Kubernetes With Pouchto make it friendlyⅡ. Does this pull request fix one issue?
None
Ⅲ. Describe how you did it
Modify the document docs/kubernetes/pouch_with_kubernetes_deploying.md
Add script file hack/kubernetes/allinone_aliyun.sh
Update script file hack/kubernetes/allinone.sh
By the way , @idealhack
Ⅳ. Describe how to verify it
Execute the script file, and then choose the option that you want :
After initializing the master node, you may get the following prompt:
Ⅴ. Special notes for reviews