Skip to content

Conversation

@Ace-Tang
Copy link
Contributor

add ContainerExecInspect client api, refactor container
part in client package.
make exec exit with correct exit code.

Fixes: #344.

Signed-off-by: Ace-Tang [email protected]

Ⅰ. Describe what this PR did

add ContainerExecInspect client api, refactor container
part in client package.
make exec exit with correct exit code.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@allencloud
Copy link
Collaborator

CI fails. PTAL. @Ace-Tang

@allencloud
Copy link
Collaborator

Could you rebase this PR to the latest branch master and fix the ci failure. Thanks a lot. @Ace-Tang

add ContainerExecInspect client api, refactor container
part in client package.
make exec exit with correct exit code.

Fixes: #344.

Signed-off-by: Ace-Tang <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1128 into master will decrease coverage by 1.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
- Coverage   16.44%   15.29%   -1.15%     
==========================================
  Files         182      173       -9     
  Lines       11295    10679     -616     
==========================================
- Hits         1857     1633     -224     
+ Misses       9302     8926     -376     
+ Partials      136      120      -16
Impacted Files Coverage Δ
client/container.go 0% <ø> (ø) ⬆️
client/container_exec.go 0% <0%> (ø)
cli/exec.go 0% <0%> (ø) ⬆️
daemon/mgr/image_utils.go 0% <0%> (-40%) ⬇️
pkg/reference/def.go 33.33% <0%> (-11.12%) ⬇️
client/client.go 58.94% <0%> (-7.06%) ⬇️
pkg/meta/boltdb.go 60.56% <0%> (-5.71%) ⬇️
daemon/mgr/container_types.go 25.31% <0%> (-4.54%) ⬇️
daemon/mgr/cri_utils.go 28.85% <0%> (-0.46%) ⬇️
apis/server/container_bridge.go 0% <0%> (ø) ⬆️
... and 39 more

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit d3c858a into AliyunContainerService:master May 11, 2018
@fuweid
Copy link
Contributor

fuweid commented May 11, 2018

Fixed #1277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is bug report for project size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] pouch exec fails but returns a zero exit code

5 participants