Skip to content

[bug] some cli options have meaningless type #2445

@mathspanda

Description

@mathspanda

Ⅰ. Issue Description

During working on #2424, I found that some cli options have meaningless type, such as --blkio-weight-device, --ulimit and so on.

      --blkio-weight-device value    Block IO weight (relative device weight), need CFQ IO Scheduler enable (default [])
      --device-read-bps value        Limit read rate (bytes per second) from a device (default [])
      --device-read-iops value       Limit read rate (IO per second) from a device (default [])
      --device-write-bps value       Limit write rate (bytes per second) from a device (default [])
      --device-write-iops value      Limit write rate (IO per second) from a device (default [])
      --ulimit value                 Set container ulimit (default [])

The value type is meaningless.

Ⅱ. Describe what happened

None

Ⅲ. Describe what you expected to happen

In docker, these options are explicitly typed.

      --device-read-bps list           Limit read rate (bytes per second) from a device (default [])
      --device-write-bps list          Limit write rate (bytes per second) to a device (default [])
      --device-read-iops list          Limit read rate (IO per second) from a device (default [])
      --device-write-iops list         Limit write rate (IO per second) to a device (default [])
      --ulimit ulimit                  Ulimit options (default [])

Ⅳ. How to reproduce it (as minimally and precisely as possible)

pouch run --help | grep value
pouchd --help | grep value

Ⅴ. Anything else we need to know?

None

Ⅵ. Environment:

Os:              linux
Version:         1.0.0
APIVersion:      1.24
Arch:            amd64
BuildTime:       2018-11-06T10:38:56+08:00
GitCommit:       1.0.0-251-g5081796
GoVersion:       go1.11.2
KernelVersion:   4.4.0-31-generic

Metadata

Metadata

Assignees

Labels

kind/bugThis is bug report for project

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions