-
Notifications
You must be signed in to change notification settings - Fork 944
Closed
Labels
kind/bugThis is bug report for projectThis is bug report for project
Description
Ⅰ. Issue Description
When I resolved this issue #2395 , I revised the logic about metrics in cri package. I found that GRPCMetrics(https://github.com/alibaba/pouch/blob/master/cri/metrics/metrics.go#L23) was used in https://github.com/alibaba/pouch/blob/1f7dbf60d406210c65fb96ea4682f6d04f97773e/cri/v1alpha2/service/cri.go#L21 . But, the GRPCMetrics wasn't registered to defaultPrometheusRegistry or customPrometheusRegistry.
Ⅱ. Describe what happened
- GRPCMetrics wasn't registered
- Not found any metric about gRPC
Ⅲ. Describe what you expected to happen
We should register GRPCMetrics to registry about Prometheus. After that, we can see the metrics through curl http://xxx/metrics
Ⅳ. How to reproduce it (as minimally and precisely as possible)
If someone can help me to identify this bug, I will revise it together with #2395.
Ⅴ. Anything else we need to know?
Ⅵ. Environment:
- pouch version (use
pouch version): - OS (e.g. from /etc/os-release):
- Kernel (e.g.
uname -a): - Install tools:
- Others:
Metadata
Metadata
Assignees
Labels
kind/bugThis is bug report for projectThis is bug report for project