Skip to content

Allowing dynamic dispatch to actual class when using NibOwnerLoadable protocol #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 3 commits into from
Oct 23, 2019
Merged

Allowing dynamic dispatch to actual class when using NibOwnerLoadable protocol #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b264b49
allow dynamic dispatch to the actual class
calmez Oct 23, 2019
280a5c3
added dynamic dispatch nib lookup change to CHANGELOG
calmez Oct 23, 2019
2468c00
fixing whitespaces for markdown to render correctly
calmez Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
# CHANGELOG

## Unreleased

* Fix nib name lookup when using subclassing.
[@calmez](https://github.com/calmez)
[#96](https://github.com/AliSoftware/Reusable/pull/96)

## 4.1.0

* Support for Swift 5.0
* Support for Swift 5.0
[@florentmorin](https://github.com/florentmorin)
[#80](https://github.com/AliSoftware/Reusable/pull/80)

## 4.0.5

* Fix for only allowing the use of app extension API.
* Fix for only allowing the use of app extension API.
[@igorkulman](https://github.com/igorkulman)
[#73](https://github.com/AliSoftware/Reusable/pull/73)

Expand Down
2 changes: 1 addition & 1 deletion Sources/View/NibOwnerLoadable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public extension NibOwnerLoadable where Self: UIView {
*/
func loadNibContent() {
let layoutAttributes: [NSLayoutConstraint.Attribute] = [.top, .leading, .bottom, .trailing]
for case let view as UIView in Self.nib.instantiate(withOwner: self, options: nil) {
for case let view as UIView in type(of: self).nib.instantiate(withOwner: self, options: nil) {
view.translatesAutoresizingMaskIntoConstraints = false
self.addSubview(view)
NSLayoutConstraint.activate(layoutAttributes.map { attribute in
Expand Down