Skip to content

Updated README for updated details on supported Swift Versions and Installation guides. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AliSoftware merged 4 commits into from
Nov 9, 2019
Merged

Updated README for updated details on supported Swift Versions and Installation guides. #95

AliSoftware merged 4 commits into from
Nov 9, 2019

Conversation

@kuyazee
Copy link
Contributor

@kuyazee kuyazee commented Oct 3, 2019

Updated README for updated details on supported Swift Versions and Installation guides.

@AliSoftware
Copy link
Owner

AliSoftware commented Oct 15, 2019

Thanks!

Now that we're ready to support latest SPM too, would you mind also integrating a paragraph on how to install with SPM too, in addition to your instructions for Carthage and CocoaPods?
(@MortyMerr and @pahnev feel free to help)

Additionally, @kuyazee please add an entry in the CHANGELOG.md to credit yourself for this documentation fix 😉

AliSoftware
AliSoftware reviewed Oct 23, 2019
View reviewed changes
README.md
…
]
)
```
Copy link
Owner

@AliSoftware AliSoftware Oct 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MortyMerr can you validate that the example is right? (Never actually integrated Reusable on another project via SPM, so another look from someone who already did could be nice)

Copy link

@tbaranes tbaranes Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try it directly with Reusable, but I confirm that the syntax used in the example is right.

@AliSoftware AliSoftware mentioned this pull request Oct 23, 2019
Closed
tbaranes
tbaranes reviewed Nov 9, 2019
View reviewed changes
Copy link

@tbaranes tbaranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's missing here? It would be great to see this merged :)

@AliSoftware
Copy link
Owner

AliSoftware commented Nov 9, 2019

I'll merge this then; but won't be able to publish an official new release until next week since I'm currently visiting Japan, without any Mac at hand 😛

@AliSoftware AliSoftware merged commit 8d05d4f into AliSoftware:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliSoftware AliSoftware AliSoftware left review comments

+1 more reviewer

@tbaranes tbaranes tbaranes left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kuyazee @AliSoftware @tbaranes