-
Notifications
You must be signed in to change notification settings - Fork 234
Update Swift package manifest to include supported platforms #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I see you merged the other pr, but this was the ”correct” solution and didn’t require any source changes |
|
@pahnev Thanks a lot for the PR! Since I think you're right and your solution might make more sense, could you rebase your PR on top of the current Also, adding an entry in the |
|
Sorry, what do you mean by "correct"? U can't fix SPM without |
|
I don't think you need to "fix SPM" with |
|
@AliSoftware did you test this solution? |
|
At least we should re-test after setting the platform in the Package.swift. If |
|
No, swift knows nothing about UIKit, doesn't matter which platform you specified :) |
|
Nope I didn't test it (I'm on my iPad without a Mac at hand rn 😥) which is why I asked for help to test this and validate if this would work 😜 |
|
I can see, that you already asked to revert my changes
Please don't do it, cause this won't work :( |
|
Then in that case let's only add |
|
@AliSoftware, changed package to only have those platforms. Feel free to add changelog. |
Define platforms in spm manifest.