Skip to content

Conversation

@pahnev
Copy link
Contributor

@pahnev pahnev commented Oct 1, 2019

Define platforms in spm manifest.

@pahnev
Copy link
Contributor Author

pahnev commented Oct 15, 2019

I see you merged the other pr, but this was the ”correct” solution and didn’t require any source changes

@AliSoftware AliSoftware mentioned this pull request Oct 15, 2019
@AliSoftware
Copy link
Owner

@pahnev Thanks a lot for the PR!

Since I think you're right and your solution might make more sense, could you rebase your PR on top of the current develop please, to revert the #if canImport(UIKit) and put your changes in instead?

Also, adding an entry in the CHANGELOG (for upcoming version 4.1.1) – crediting both @MortyMerr / #89 + you / this #93 – would be great too!

@M0rtyMerr
Copy link
Contributor

Sorry, what do you mean by "correct"? U can't fix SPM without canImport(UIKit). swift build won't work on that. What's the reason of reverting changes?

@AliSoftware
Copy link
Owner

I don't think you need to "fix SPM" with canImport if you restrict it to platforms: [.iOS(.v8),.tvOS(.v9)] like in this PR do you?

@M0rtyMerr
Copy link
Contributor

@AliSoftware did you test this solution?

@AliSoftware
Copy link
Owner

At least we should re-test after setting the platform in the Package.swift. If canImport is still needed we should keep it indeed (though I'm hoping that swift build only builds for the specified platforms) but in any case adding the platforms is still useful

@M0rtyMerr
Copy link
Contributor

No, swift knows nothing about UIKit, doesn't matter which platform you specified :)

@AliSoftware
Copy link
Owner

Nope I didn't test it (I'm on my iPad without a Mac at hand rn 😥) which is why I asked for help to test this and validate if this would work 😜

@M0rtyMerr
Copy link
Contributor

M0rtyMerr commented Oct 15, 2019

I can see, that you already asked to revert my changes

Since I think you're right and your solution might make more sense, could you rebase your PR on top of the current develop please, to revert the #if canImport(UIKit)

Please don't do it, cause this won't work :(

@AliSoftware
Copy link
Owner

Then in that case let's only add platforms and CHANGELOG 🤷‍♂️

@pahnev pahnev closed this Oct 17, 2019
@pahnev pahnev reopened this Oct 17, 2019
@pahnev pahnev changed the title Update Swift package manifest to work with Xcode 11 Update Swift package manifest to include supported platforms Oct 17, 2019
@pahnev
Copy link
Contributor Author

pahnev commented Oct 21, 2019

@AliSoftware, changed package to only have those platforms. Feel free to add changelog.

@AliSoftware AliSoftware merged commit 6b93223 into AliSoftware:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants