Allowing extension only API #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
reviewed
Dec 2, 2018
Owner
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Thanks ! I think a CHANGELOG entry would still be worth it so that people who expected it to work in the current version will know it has been fixed 😉
AliSoftware
approved these changes
Dec 2, 2018
Owner
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second take on #69, this time finally working correctly. Not sure if you need a Changelog entry because it is the same as 4.0.4 just that it really works this time 😄
Xcode did some additional changes to the project as you can see, basically upgrading the definition to Xcode 10. Hope that is OK because it is not easy only commiting the required change (would involve manually editing
project.pbxprojinstead of using Xcode).