Skip to content

Conversation

@igorkulman
Copy link
Contributor

Fixes #69

@AliSoftware
Copy link
Owner

Cool! Thanks a lot for taking the time to do the PR!

Could you just add an entry in the CHANGELOG.md to mention that change and credit yourself? Thanks!

@AliSoftware
Copy link
Owner

Sorry, I should have mentioned in my previous comment: the new entry shouldn't go under ## 4.0.3 — which is already released — but under a new entry that I usually call ## Master to list fixes not yet released (I then change that ## Master entry to ## 4.0.4 or ## 4.1.0 or what's the next version will be when I actually do the release of the next version)

@igorkulman
Copy link
Contributor Author

No problem, fixed.

@AliSoftware
Copy link
Owner

This seems perfect 👌 thanks a lot! 🙌

@AliSoftware AliSoftware merged commit b4c0a8f into AliSoftware:master Oct 13, 2018
@AliSoftware
Copy link
Owner

Reusable 4.0.4 has just been released to include your fix (I finally decided to do a release right away after your fix) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants