Increasing safety in loadFromNib

CHANGELOG.md

@@ -1,5 +1,25 @@
 # CHANGELOG
 
+## Unreleased
+
+* Removing a parameter from `loadFromNib(owner:)` method in `NibOwnerLoadable` due to a possibility of calling `init()` or
+  `init(frame:)` initializers which might led to a crash if `init(frame:)` was not implemented in a custom UIView subclass
+  (because it is not a required initializer).
+  Additionally, changing `loadFromNib(owner:)` to an instance method as for
+  classes conforming to NibOwnerLoadable, the instance of a class is already instantiated (i.e. when loading from other
+  XIBs). However, it is still possible to load such a view programatically.
+
+    ⚠️ **BREAKING CHANGES** ⚠️ The following method has a new signature:
+    - `static func loadFromNib(owner:)` is now `func loadNibContent()`
+    [@Skoti](https://github.com/Skoti)
+    [#40](https://github.com/AliSoftware/Reusable/pull/40)
+
+* Fixing incorrect protocol naming in documentation comments for CollectionHeaderView and MyXIBIndexSquaceCell
+  [@Skoti](https://github.com/Skoti)
+
+* Fixing table view controller scene to display cells above UITabBar
+  [@Skoti](https://github.com/Skoti)
+
 ## 3.0.1
 
 * Fix `instantiate()` implementation on `StoryboardSceneBased` ViewControllers.  

Example/ReusableDemo/Base.lproj/Main.storyboard

@@ -1,5 +1,5 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="10117" systemVersion="15G31" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" initialViewController="7fF-Ae-xTS">
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="10117" systemVersion="16D32" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" initialViewController="7fF-Ae-xTS">
     <dependencies>
         <deployment identifier="iOS"/>
         <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="10085"/>
@@ -90,6 +90,7 @@
                             <outlet property="delegate" destination="Spa-tB-Bt1" id="iqn-sB-Tfo"/>
                         </connections>
                     </tableView>
+                    <extendedEdge key="edgesForExtendedLayout" top="YES"/>
                     <tabBarItem key="tabBarItem" title="TableView" id="C3o-Lt-Bjj"/>
                 </tableViewController>
                 <placeholder placeholderIdentifier="IBFirstResponder" id="XEN-tN-mKX" userLabel="First Responder" sceneMemberID="firstResponder"/>

Example/ReusableDemo/CollectionViewCells/CollectionHeaderView.swift

@@ -16,7 +16,7 @@ import Reusable
  * It is also reusable and has a `reuseIdentifier` (as it's a CollectionViewCell
  * and it uses the CollectionView recycling mechanism) => it is `Reusable`
  *
- * That's why it's annotated with the `NibOwnerLoadable` protocol,
+ * That's why it's annotated with the `NibReusable` protocol,
  * Which in fact is just a convenience typealias that combines
  * `NibLoadable` & `Reusable` protocols.
  */

Example/ReusableDemo/CollectionViewCells/MyXIBIndexSquaceCell.swift

@@ -16,7 +16,7 @@ import Reusable
  * It is also reusable and has a `reuseIdentifier` (as it's a CollectionViewCell
  * and it uses the CollectionView recycling mechanism) => it is `Reusable`
  *
- * That's why it's annotated with the `NibOwnerLoadable` protocol,
+ * That's why it's annotated with the `NibReusable` protocol,
  * Which in fact is just a typealias that combines
  * `NibLoadable` & `Reusable` protocols.
  */

Example/ReusableDemo/CustomViews/MyCustomWidget.swift

@@ -26,9 +26,6 @@ class MyCustomWidget: UIView, NibOwnerLoadable {
 
   required init?(coder aDecoder: NSCoder) {
     super.init(coder: aDecoder)
-    MyCustomWidget.loadFromNib(owner: self)
-  }
-  override init(frame: CGRect) {
-    super.init(frame: frame)
+    self.loadNibContent()
   }
 }

Example/ReusableDemo/TableViewCells/MyHeaderTableView.swift

@@ -15,7 +15,7 @@ import Reusable
  *
  * That's why it's annotated with the `NibOwnerLoadable` protocol.
  */
-final class MyHeaderTableView: UIView, NibOwnerLoadable, FrameInitializable {
+final class MyHeaderTableView: UIView, NibOwnerLoadable {
 
   @IBOutlet private weak var titleLabel: UILabel!
   static let height: CGFloat = 55

Example/ReusableDemo/TableViewController.swift

@@ -27,7 +27,8 @@ final class TableViewController: UITableViewController {
   }
 
   override func tableView(_ tableView: UITableView, viewForHeaderInSection section: Int) -> UIView? {
-    let view = MyHeaderTableView.loadFromNib()
+    let view = MyHeaderTableView(frame: CGRect(x: 0, y: 0, width: tableView.bounds.size.width, height: self.tableView(tableView, heightForHeaderInSection: section)))
+    view.loadNibContent()
     view.fillForSection(section)
     return view
   }

README.md

@@ -297,17 +297,14 @@ final class MyCustomWidget: UIView, NibOwnerLoadable {
   …
   required init?(coder aDecoder: NSCoder) {
     super.init(coder: aDecoder)
-    MyCustomWidget.loadFromNib(owner: self)
-  }
-  override init(frame: CGRect) {
-    super.init(frame: frame)
+    self.loadNibContent()
   }
 }
 ```
 
 Overriding `init?(coder:)` allows your `MyCustomWidget` custom view to load its content from the associated XIB `MyCustomWidget.xib` and add it as subviews of itself.
 
-_💡 Note: overriding `init(frame:)`, even just to call `super.init(frame: frame)` might seems pointless, but seems necessary in some cases due to a strange issue with Swift and dynamic dispatch not being able to detect and call the superclass implementation all by itself: I've sometimes seen crashes when not implementing it explicitly, so better safe than sorry._
+_💡 Note: possible to override `init(frame:)`, in order to be able to create an instance of that view programatically and call `loadNibContent()` to fill with views if needed.
 
 ## 3b. Instantiating a `NibLoadable` view
 
@@ -322,8 +319,6 @@ let view3 = NibBasedRootView.loadFromNib() // and another one
 …
 ```
 
-> 💡 You could also use `MyCustomWidget.loadFromNib()` on a `NibOwnerLoadable` — the same way we just did on `NibLoadable` views above — to load them by code if needs be too.
-
 ---
 
 

Sources/View/NibOwnerLoadable.swift

@@ -41,38 +41,22 @@ public extension NibOwnerLoadable where Self: UIView {
    - returns: A `NibOwnerLoadable`, `UIView` instance
    */
   @discardableResult
-  static func loadFromNib(owner: Self) -> Self {
+  func loadNibContent() {
     let layoutAttributes: [NSLayoutAttribute] = [.top, .leading, .bottom, .trailing]
-    for view in nib.instantiate(withOwner: owner, options: nil) {
+    for view in Self.nib.instantiate(withOwner: self, options: nil) {
       if let view = view as? UIView {
         view.translatesAutoresizingMaskIntoConstraints = false
-        owner.addSubview(view)
+        self.addSubview(view)
         layoutAttributes.forEach { attribute in
-          owner.addConstraint(NSLayoutConstraint(item: view,
+          self.addConstraint(NSLayoutConstraint(item: view,
             attribute: attribute,
             relatedBy: .equal,
-            toItem: owner,
+            toItem: self,
             attribute: attribute,
             multiplier: 1,
             constant: 0.0))
         }
       }
     }
-    return owner
   }
 }
-
-public protocol FrameInitializable: class {
-    init(frame: CGRect)
-}
-
-public extension NibOwnerLoadable where Self: UIView, Self: FrameInitializable {
-    /**
-     Returns a `UIView` object instantiated from nib using a default owner instance
-
-     - returns: A `NibOwnerLoadable`, `UIView`, `FrameInitializable` instance
-     */
-    static func loadFromNib() -> Self {
-        return Self.loadFromNib(owner: Self(frame: CGRect.zero))
-    }
-}