400 Bad Request on PUT /api/streams because of multi-line string in YAML

[felipecrs]

1. Create a go2rtc config like this one:

streams:
  birdseye: exec:/usr/lib/ffmpeg/5.0/bin/ffmpeg -hide_banner -hwaccel vaapi -hwaccel_output_format
    vaapi -hwaccel_device /dev/dri/renderD128 -f rawvideo -pix_fmt yuv420p -video_size
    1280x720 -r 10 -i /tmp/cache/birdseye -c:v h264_vaapi -g 50 -bf 0 -profile:v high
    -level:v 4.1 -sei:v 0 -an -vf format=vaapi|nv12,hwupload -rtsp_transport tcp -f
    rtsp {output}

Note: this is valid YAML.

Now, try to:

$ curl -fsSL -X PUT 'http://192.168.1.10:1984/api/streams?name=test&src=rtsp://192.168.1.10:8554/test'
curl: (22) The requested URL returned error: 400

When doing from UI:

[AlexxIT]

Can confirm that. Bug with editing yaml on the fly.

[felipecrs]

Forgot to mention that in real life this blocks all Frigate users (EDIT: Frigate users with birdseye restream enabled) from using the go2rtc running within Frigate with the Home Assistant official integration like below:

# configuration.yaml
go2rtc:
  url: http://ccab4aaf-frigate:1984

[AlexxIT]

This blocks only users with so strange config :)
Although it does count as valid YAML, typical form of a multi-line YAML record:

streams:
  birdseye: >-
    exec:/usr/lib/ffmpeg/5.0/bin/ffmpeg -hide_banner -hwaccel vaapi -hwaccel_output_format
    vaapi -hwaccel_device /dev/dri/renderD128 -f rawvideo -pix_fmt yuv420p -video_size
    1280x720 -r 10 -i /tmp/cache/birdseye -c:v h264_vaapi -g 50 -bf 0 -profile:v high
    -level:v 4.1 -sei:v 0 -an -vf format=vaapi|nv12,hwupload -rtsp_transport tcp -f
    rtsp {output}

https://yaml-multiline.info/

[felipecrs]

This blocks only users with so strange config :)

Which happens to be all Frigate users that has birdseye restream enabled:

https://github.com/blakeblackshear/frigate/blob/0128ec2ba60ac5229b8f88c3c271dc6e078da4c4/docker/main/rootfs/usr/local/go2rtc/create_config.py#L161

[AlexxIT]

So yaml.dump from python makes this kind of config? I'll fix that in the next release.

[felipecrs]

Exactly.

[felipecrs]

I mean, I could probably suggest Frigate to use a different library or function to create the YAML config, but given this is valid YAML anyway, I thought the best would be to fix it in go2rtc instead.

[AlexxIT]

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.9