-
Notifications
You must be signed in to change notification settings - Fork 522
AlamofireImageExtended Types #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // | ||
| // AlamofireImageExtended.swift | ||
| // | ||
| // Copyright (c) 2020 Alamofire Software Foundation (http://alamofire.org/) | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
| // | ||
|
|
||
| /// Type that acts as a generic extension point for all `AlamofireImageExtended` types. | ||
| public struct AlamofireImageExtension<ExtendedType> { | ||
| /// Stores the type or metatype of any extended type. | ||
| let type: ExtendedType | ||
|
|
||
| init(_ type: ExtendedType) { | ||
| self.type = type | ||
| } | ||
| } | ||
|
|
||
| // MARK: - | ||
|
|
||
| /// Protocol describing the `af` extension points for AlamofireImage extended types. | ||
| public protocol AlamofireImageExtended { | ||
| /// Type being extended. | ||
| associatedtype ExtendedType | ||
|
|
||
| /// Static AlamofireImage extension point. | ||
| static var af: AlamofireImageExtension<ExtendedType>.Type { get set } | ||
| /// Instance AlamofireImage extension point. | ||
| var af: AlamofireImageExtension<ExtendedType> { get set } | ||
| } | ||
|
|
||
| // MARK: - | ||
|
|
||
| public extension AlamofireImageExtended { | ||
| /// Static AlamofireImage extension point. | ||
| static var af: AlamofireImageExtension<Self>.Type { | ||
| get { return AlamofireImageExtension<Self>.self } | ||
| set {} | ||
| } | ||
|
|
||
| /// Instance AlamofireImage extension point. | ||
| var af: AlamofireImageExtension<Self> { | ||
| get { return AlamofireImageExtension(self) } | ||
| set {} | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from needing to make
typeandinitpublic, we could useAlamofireExtendedinstead here, and I'd hoped to when adding it to Alamofire. Since we're reusing theafextension point anyway, not duplicating the extension methodology seems like a good idea.