feat: Use ThreadPoolExecutor for parallel conversion. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👋 Hello! The idea is right. But, as it always happens with AI, the code quality is horrible. It can be improved with some refactoring though. You can try refactoring yourself, or leave it to me. |
Make conversion thread-safe and concurrent with cancel support. Co-authored-by: aider (ollama_chat/gpt-oss) <[email protected]>
Author
|
Feel free to refactor it, I would have used joblib, except I didn't want to include another dependency 😄 |
tatsumoto-ren
force-pushed
the
threadpool
branch
from
ad03088 to
dfad4a1
Compare
Member
|
Can merge like this if everything is fine. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make conversion thread-safe and concurrent with cancel support.
This commit was generated with AI assistance. Please let me know if any changes should be made.