-
Notifications
You must be signed in to change notification settings - Fork 243
Add Slack channel link to the projects show page #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tansaku
merged 16 commits into
AgileVentures:develop
from
NickSchimek:770_add_link_to_projects_slack_channel
Jul 30, 2018
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
157aaa7
Add tests for viewing the projects API links
NickSchimek 2297255
Add slack channel link to show page
NickSchimek 68d6c71
Add slack channel name to tests
NickSchimek 1dcbcde
Update slack link assertion
NickSchimek bf53c9c
Run migration to add slack channel name
NickSchimek dc0e11e
Update link to use the slack channel name
NickSchimek 8aed4d9
Fix grammar in cucumber test
NickSchimek 6f01caa
Add CRUD tests for slack channel name
NickSchimek f618c43
Update CRUD views to include slack channel name
NickSchimek 48f8e2e
Add test for when slack channel does not exist
NickSchimek 70f8673
Update view to render correct slack status
NickSchimek f41f423
Update test to check the views else route
NickSchimek 94f8a76
Remove building source repository
NickSchimek 28c0e6a
Update tests now that source repo is not built
NickSchimek 420a3e0
Replace hard link with param name
NickSchimek 696390e
Permit slack channel name params
NickSchimek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
db/migrate/20180729040001_add_slack_channel_name_to_projects.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| class AddSlackChannelNameToProjects < ActiveRecord::Migration[5.1] | ||
| def change | ||
| add_column :projects, :slack_channel_name, :string | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| Feature: Projects should show links to the connected APIs | ||
| As a User | ||
| So that I can easily navigate to Project apps | ||
| I want to see all connected app links on the show page | ||
|
|
||
| Background: | ||
| Given the following users exist | ||
| | first_name | last_name | email | receive_mailings | | ||
| | Bill | Bob | [email protected] | true | | ||
|
|
||
| Given the following projects exist: | ||
| | title | description | status | author | pivotaltracker_url | github_url | slack_channel_name | | ||
| | hello | earthlings | active | Bill | https://www.pivotaltracker.com/n/projects/742821 | https://github.com/hello | hello_earthlings | | ||
| | Bat Man | All bat | active | Bill | | | | | ||
|
|
||
| Scenario: I can see a link to the GitHub project page | ||
| When I go to the "hello" project "show" page | ||
| Then I should see "hello on GitHub" | ||
| And I should see a link to "hello" on github | ||
|
|
||
| Scenario: I can see when a project is not connected to GitHub | ||
| When I go to the "Bat Man" project "show" page | ||
| Then I should not see "Bat Man on GitHub" | ||
| And I should see "not linked to GitHub" | ||
|
|
||
| Scenario: I can see a link to the projects issue tracker | ||
| When I go to the "hello" project "show" page | ||
| Then I should see "hello on IssueTracker" | ||
| And I should see a link to "hello" on Pivotal Tracker | ||
|
|
||
| Scenario: I can see when a project is not connected to issue tracker | ||
| When I go to the "Bat Man" project "show" page | ||
| Then I should not see "Bat Man on IssueTracker" | ||
| And I should see "not linked to IssueTracker" | ||
|
|
||
| Scenario: I can see a link to the projects slack channel | ||
| When I go to the "hello" project "show" page | ||
| Then I should see "hello on Slack" | ||
| And I should see a link to the slack channel for "hello" | ||
|
|
||
| Scenario: I can see when a project is not connected to slack | ||
| When I go to the "Bat Man" project "show" page | ||
| Then I should not see "Bat Man on Slack" | ||
| And I should see "not linked to Slack" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if some of this could be condensed down with a "Scenario Outline"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will take a look at that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to open a new refactoring ticket for that :-)