fix(harness): preserve provider errors when schema output file is missing#218
Closed
santoshkumarradha wants to merge 2 commits intomainfrom
Closed
fix(harness): preserve provider errors when schema output file is missing#218santoshkumarradha wants to merge 2 commits intomainfrom
santoshkumarradha wants to merge 2 commits intomainfrom
Conversation
…sing Keep provider failure context when schema-mode output parsing fails and no output file exists, so runtime/provider failures are not mislabeled as schema validation errors.
Contributor
Performance
✓ No regressions detected |
- Rewrite opencode.py: auto-managed serve+attach pattern to bypass opencode v1.2.10-v1.2.16 'Session not found' bug - Add project_dir field to HarnessConfig (types.py) so coding agents explore the target repo instead of a temp working directory - Add output file placement inside project_dir (runner) so sandboxed Write tool can reach the output JSON - Pass server_url to OpenCodeProvider via factory - Clean up debug prints from runner and claude provider - Verified working with openrouter/moonshotai/kimi-k2.5 model
Member
Author
|
Superseded by #220 (combined harness PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agentfield_output.jsonwas never createdWhy
Schema-mode failures currently mask real provider/runtime failures (for example
opencode runreturningSession not found) behindSchema validation failed..., which makes diagnosis noisy and misleading.Verification
permission_mode=auto) on/tmp/dvgaand confirmed complex schemas parse successfully from file output (parsed != NoneforArchitectureMapandReconResult).