[configurationwebhooks] Code generation: update services and models#521
[configurationwebhooks] Code generation: update services and models#521AdyenAutomationBot wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request consists of automated code generation to update services and models for configurationwebhooks. The changes include adding several new models, updating comments for clarity, and modifying existing models to align with the latest API specification. The new models and modifications, such as making the Card.Number field optional and adding new address fields, are implemented consistently and correctly. The updates to enum values and documentation comments are also noted. Overall, the changes appear to be a standard and correct update for the API client library, and no issues of medium or higher severity were found.
33c3347 to
f81e807
Compare
jeandersonbc
left a comment
There was a problem hiding this comment.
This PR has a change to the signature of exported functions. Marking this as a breaking change.
There was a problem hiding this comment.
optional fields added to existing model
| func NewCard(brand string, brandVariant string, cardholderName string, formFactor string, number string) *Card { | ||
| func NewCard(brand string, brandVariant string, cardholderName string, formFactor string) *Card { | ||
| this := Card{} | ||
| this.Brand = brand | ||
| this.BrandVariant = brandVariant | ||
| this.CardholderName = cardholderName | ||
| this.FormFactor = formFactor | ||
| this.Number = number | ||
| return &this | ||
| } |
There was a problem hiding this comment.
requires changes on projects that already use this model. Marking this as a breaking change.
f81e807 to
e7e0356
Compare
e7e0356 to
722a883
Compare
This PR contains the automated changes for the
configurationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.