Skip to content

Conversation

@bajrangCoder
Copy link
Collaborator

@bajrangCoder bajrangCoder commented Apr 7, 2025

Demo

Screenshot_20250407-172107

Screenshot_20250407-202348~2

@bajrangCoder bajrangCoder requested a review from Copilot April 7, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/components/sidebar/style.scss: Language not supported
Comments suppressed due to low confidence (3)

src/lib/auth.js:22

  • Ensure the DATA_STORAGE variable is defined or imported in this module to avoid runtime errors during token file operations.
return await fsOperation(`${DATA_STORAGE}.acode_token`).exists();

src/components/sidebar/index.js:198

  • Use 'userAvatar.el.append(avatarImg)' instead of 'userAvatar.append(avatarImg)' to properly reference the underlying DOM element.
userAvatar.append(avatarImg);

src/components/sidebar/index.js:203

  • Use 'userAvatar.el.append(defaultIcon)' instead of 'userAvatar.append(defaultIcon)' to correctly append the element to the DOM.
userAvatar.append(defaultIcon);

@peasneovoyager2banana2
Copy link
Contributor

peasneovoyager2banana2 commented Apr 7, 2025

Before merging I would suggest not displaying email address by default so that we ourselves don't have to spend extra time editing screenshots or screen recordings just to hide it

@bajrangCoder
Copy link
Collaborator Author

Before merging I would suggest not displaying email address by default so that we ourselves don't have to spend extra time editing screenshots or screen recordings just to hide it

That's a public email.
Btw why anybody will take screenshot of sidebar with opened menu?

@peasneovoyager2banana2
Copy link
Contributor

peasneovoyager2banana2 commented Apr 9, 2025

* That's a public email.

Some people may want to prefer to use their private email to login with, which for those with privacy concerns is not recommended when the site also publicly displays the email*, although if they used their private email already they should change it to a public email in the account settings for now

*In acode website's case the email it's just visible on the profile's URL
Screenshot_20250409-033036_Chrome

@deadlyjack
Copy link
Collaborator

deadlyjack commented Apr 9, 2025 via email

@bajrangCoder
Copy link
Collaborator Author

* That's a public email.

Some people may want to prefer to use their private email to login with, which for those with privacy concerns is not recommended when the site also publicly displays the email*, although if they used their private email already they should change it to a public email in the account settings for now

*In acode website's case the email it's just visible on the profile's URL Screenshot_20250409-033036_Chrome

That's a issue on website but there is no problem with showing email in app(like a profile or something)

@bajrangCoder bajrangCoder merged commit 28e4dc6 into Acode-Foundation:main Apr 10, 2025
2 checks passed
@bajrangCoder bajrangCoder deleted the inapp-login branch May 9, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants