fix: Redraw only when needed in the winit examples #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@PoignardAzur Maybe you can help check this one? Nothing related to accessibility but it can be a good introduction if you have never read these examples. Thanks. |
DataTriny
force-pushed
the
fix-examples-redraw
branch
from
29194e9 to
f8f3051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not test #625 on macOS where it actually make the example very unresponsive. This is because we are constantly redrawing the screen, not giving much CPU time for accessibility calls to be handled on the main thread. Triggering a redraw only when needed (or when it would be needed in a real program) solves the issue.