Handle content-type correctly (api, /messages)#61
Merged
kevinbader merged 3 commits intomasterfrom May 29, 2018
Merged
Conversation
Contributor
kevinbader
commented
Apr 4, 2018
kevinbader
commented
- Allow MIME type options like ';charset=utf-8' for json content-type
- Allow application/x-www-form-urlencoded and multipart encodings
- Return "415 Unsupported Media Type" for unknown content-types
Collaborator
|
Works, but perhaps you should add few small tests (for |
kevinbader
force-pushed
the
post-msg-content-type
branch
from
3e81731 to
5166319
Compare
- Allow MIME type options like ';charset=utf-8' for json content-type - Allow application/x-www-form-urlencoded and multipart encodings - Return "415 Unsupported Media Type" for unknown content-types
kevinbader
force-pushed
the
post-msg-content-type
branch
from
5166319 to
b890cd7
Compare
mmacai
approved these changes
May 28, 2018
Collaborator
mmacai
left a comment
mmacai
left a comment
There was a problem hiding this comment.
Works well even with example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.