Conversation
do you think we should use |
I read somewhere, that using |
| end | ||
|
|
||
| @tag :smoke | ||
| test "not subscribed user shouldn'\t receive message", %{conn: conn} do |
There was a problem hiding this comment.
tab character ... typo?
There was a problem hiding this comment.
ye, that's a typo ... used to do automatic escaping of special characters from JS
|
Found one typo.. other than that it looks good to me |
kevinbader
left a comment
There was a problem hiding this comment.
I get a compile-time warning:
==> rig_outbound_gateway
Compiling 7 files (.ex)
warning: definitions with multiple clauses and default values require a header. Instead of:
def foo(:first_clause, b \\ :default) do ... end
def foo(:second_clause, b) do ... end
one should write:
def foo(a, b \\ :default)
def foo(:first_clause, b) do ... end
def foo(:second_clause, b) do ... end
def wait_for_consumer_ready/3 has multiple clauses and defines defaults in one or more clauses
lib/rig_outbound_gateway/kafka/group_subscriber.ex:123
|
Instructions worked like charm, tests seem to work. |
|
|
||
| @spec wait_for_consumer_ready(String.t(), integer, integer) :: {:ok, String.t()} | ||
| def wait_for_consumer_ready(topic, partition, timeout \\ 10_000) do | ||
| def wait_for_consumer_ready(topic, partition, timeout) do |
There was a problem hiding this comment.
just a minor comment about the two specs: having one spec per function clause is optional and makes perfect sense if there something like "if I put a String.t in there, I get a String.t out, but if I put an atom in there, it'll be an atom" (you get the idea). However, in this case I feel it would be clearer (and less to write/read/maintain) to have just one combined spec, as I don't see any gain in expressing the same thing using two lines:
@spec wait_for_consumer_ready(String.t(), integer, integer) :: {:ok | :error, String.t()}What do you think?
PS: I think integer here should actually be non_neg_integer() in both cases
.dockerignore- unused => we are selectively picking files in Dockerfile anywayTest:
mix testshould work as beforeCloses #33