Skip to content

278 - removed deprecated apis env vars and related code/docs#336

Merged
mmacai merged 10 commits intomasterfrom
278-remove-deprecations
Nov 13, 2020
Merged

278 - removed deprecated apis env vars and related code/docs#336
mmacai merged 10 commits intomasterfrom
278-remove-deprecations

Conversation

@mmacai
Copy link
Copy Markdown
Collaborator

@mmacai mmacai commented Nov 1, 2020

Description

Closes #278

  • removed deprecated and unused code
  • fixed some npm audit issues

What to look out for

  • pretty much take a look at the changelog and removed stuff
  • run all test suites - unit, smoke, integration, cypress - everything should be green

Process

The goal is to improve not only the code in this PR but also our skills! The "rules":

  • The review is considered "done" as soon as all reviewers have added their review, and all their comments have been addressed.
  • For knowledge-sharing reviews, each reviewer should "approve" the PR after studying its content.
  • After the approval, the merge is concluded by the developer.

Have fun!

@mmacai mmacai marked this pull request as ready for review November 2, 2020 12:40
@mmacai mmacai changed the title WIP: 278 - removed deprecated apis env vars and related code/docs 278 - removed deprecated apis env vars and related code/docs Nov 2, 2020
@mmacai mmacai requested a review from kevinbader November 2, 2020 12:43
Comment thread lib/rig_inbound_gateway/api_proxy/handler/nats.ex Outdated
kevinbader
kevinbader previously approved these changes Nov 12, 2020
@mmacai mmacai merged commit 06ee2bf into master Nov 13, 2020
@mmacai mmacai deleted the 278-remove-deprecations branch November 13, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support for deprecated way to pass events to reverse proxy endpoints

2 participants