Conversation
Collaborator
Author
|
@kevinbader still have to do some testing and probably missed some places to update, but you can already give it a shot. |
kevinbader
suggested changes
Aug 4, 2020
kevinbader
suggested changes
Aug 12, 2020
|
|
||
| #### Supported formats | ||
|
|
||
| All `response_from` options support only binary mode. |
Contributor
There was a problem hiding this comment.
Not an issue, just a thought: is "binary mode" a common term outside the cloudevents spec?
Collaborator
Author
There was a problem hiding this comment.
No idea tbh, but I guess it makes sense to be consistent with such terms.
| |> Tracing.Plug.put_resp_header(Tracing.context()) | ||
| |> Conn.put_resp_content_type("application/json") | ||
| |> Conn.send_resp(:ok, response) | ||
| |> Conn.send_resp(response_code, response) |
Contributor
There was a problem hiding this comment.
what about the content type? Ideally, we'd forward the body as-is and also retain the content-type, then the backend can send whatever
kevinbader
reviewed
Aug 13, 2020
kevinbader
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support custom response code for these
response_fromtargets:NATS- NATS -> NATS not implemented as I wasn't able to test it properlyKinesis- Not supported atmWhat to look out for
Closes #221