Skip to content

fix script which find previous branch #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xlc merged 1 commit into from
Oct 10, 2022
Merged

fix script which find previous branch #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def get_chain_and_version(branch_name):
return chain, version

def get_previous_version(chain):
cmd = os.popen("git branch --remote | grep origin/release-{}-".format(chain));
cmd = os.popen("git branch --remote --sort=committerdate | grep origin/release-{}-".format(chain));
branches = cmd.read().split("\n")
cmd.__exit__()
branches = map(lambda x: x.strip(), branches)
Expand Down
12 changes: 6 additions & 6 deletions .github/scripts/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@

class InspectTestCase(unittest.TestCase):
def setUp(self) -> None:
os.environ["GITHUB_REF"] = "origin/release-karura-2.9.0"
os.environ["GITHUB_REF"] = "origin/release-karura-2.10.0"
return super().setUp()

def test_get_previous_version(self):
assert inspect.get_previous_version("karura") == "2.8.3"
assert inspect.get_previous_version("karura") == "2.9.5"

def test_get_chain_and_version(self):
chain, version = inspect.get_chain_and_version("origin/release-karura-2.9.0")
chain, version = inspect.get_chain_and_version("origin/release-karura-2.10.0")
assert chain == "karura"
assert version == "2.9.0"
assert version == "2.10.0"

chain, version = inspect.get_chain_and_version("release-karura-2.9.0")
chain, version = inspect.get_chain_and_version("release-karura-2.10.0")
assert chain == "karura"
assert version == "2.9.0"
assert version == "2.10.0"

if __name__ == '__main__':
unittest.main()