Skip to content

add option to pause evm precompiles#2347

Merged
xlc merged 8 commits intomasterfrom
pause_precompile
Oct 4, 2022
Merged

add option to pause evm precompiles#2347
xlc merged 8 commits intomasterfrom
pause_precompile

Conversation

@ermalkaleci
Copy link
Copy Markdown
Contributor

No description provided.

@ermalkaleci ermalkaleci requested review from xlc and zjb0807 September 16, 2022 20:51
@ermalkaleci
Copy link
Copy Markdown
Contributor Author

/bench runtime karura module_transaction_pause

Copy link
Copy Markdown
Contributor

@zjb0807 zjb0807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do we need to suspend the functionality of the contract addresses that has loophole?

@ermalkaleci
Copy link
Copy Markdown
Contributor Author

LGTM.

Do we need to suspend the functionality of the contract addresses that has loophole?

I don't think we should. If the team wants to pause something they can add the feature into their contract

@xlc xlc force-pushed the pause_precompile branch from c2fc5c7 to f9de332 Compare October 4, 2022 03:25
@xlc xlc enabled auto-merge (squash) October 4, 2022 03:53
@xlc xlc merged commit b1b8c74 into master Oct 4, 2022
@xlc xlc deleted the pause_precompile branch October 4, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants