This repository was archived by the owner on Mar 14, 2024. It is now read-only.
fix: update activeReports before checking changes#39
Draft
sleidig wants to merge 1 commit into
Draft
Conversation
sleidig
commented
Feb 28, 2024
sleidig
commented
Member
- still to be tested in full environment (with couchdb)
sleidig
force-pushed
the
fix-active-report-monitoring
branch
from
cfbd64f to
1a0c4db
Compare
sleidig
commented
Feb 28, 2024
Comment on lines
+110
to
+113
| switchMap((change: DocChangeDetails) => | ||
| // await an update of monitors for currently active reports | ||
| from(this.updateReportMonitors()).pipe(map(() => change)), | ||
| ), |
Member
Author
There was a problem hiding this comment.
We could also do a deeper refactoring and remove the ChangeDetector instances completely. But the underlying bug should be fixed ASAP, so I kept that as is for now.
sleidig
added
the
Status: Core Team Priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.