Skip to content

FIX : Interface.php has fatal errors (invisible to user) due to unprotected SQL injection of input vars #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2022
+18 −6
Merged

FIX : Interface.php has fatal errors (invisible to user) due to unprotected SQL injection of input vars #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file.

### Changed

- FIX : `Interface.php` has fatal errors (invisible to user) due to SQL
injection of empty input values - *29/06/2022* - 1.1.7
- FIX : Can't create more product prices if multidevise is enable - *01/06/2022* - 1.1.6
- FIX : UX Changes between DOL 13.0 and 14.0 so we pull the qsp form under addline tpl - *02/05/2022* - 1.1.5
- FIX : tvatx must not be converted to int, because it can have decimals and specific tva code - *30/03/2022* - 1.1.4
Expand Down
2 changes: 1 addition & 1 deletion core/modules/modquicksupplierprice.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function __construct($db)
// Module description, used if translation string 'ModuleXXXDesc' not found (where XXX is value of numeric property 'numero' of module)
$this->description = "Description of module quicksupplierprice";
// Possible values for version are: 'development', 'experimental', 'dolibarr' or version
$this->version = '1.1.6';
$this->version = '1.1.7';
// Key used in llx_const table to save module status enabled/disabled (where MYMODULE is value of property name of module in uppercase)
$this->const_name = 'MAIN_MODULE_'.strtoupper($this->name);
// Where to store the module in setup page (0=common,1=interface,2=others,3=very specific)
Expand Down
20 changes: 15 additions & 5 deletions script/interface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ function checkprice($id_prod, $unitprice, $fk_order, $qte, $price, $fk_soc, $tva
function upatePrice($id_prod, $fk_soc, $unitprice, $qte, $ref_search, $price, $ref, $tvatx){
global $db, $user;

if ($price === '' || $unitprice === '') {
print json_encode(array('retour' => 0, 'error' => 'prix non renseigné'));
return;
}

ob_start();

// Clean vat code
Expand All @@ -128,16 +133,21 @@ function upatePrice($id_prod, $fk_soc, $unitprice, $qte, $ref_search, $price, $r
}

// On vérifie si la ligne de tarif n'existe pas déjà pour ce fournisseur
$sql = "SELECT rowid FROM ".MAIN_DB_PREFIX."product_fournisseur_price WHERE fk_product=" . $id_prod;
$sql .= " AND fk_soc=" . $fk_soc;
$sql .= " AND unitprice=" . $unitprice;
$sql .= " AND quantity=" . $qte;
$sql = 'SELECT rowid FROM ' . MAIN_DB_PREFIX . 'product_fournisseur_price'
. ' WHERE fk_product=' . intval($id_prod)
. ' AND fk_soc=' . intval($fk_soc)
. ' AND unitprice=' . floatval($unitprice)
. ' AND quantity=' . intval($qte);
if (!empty($vat_src_code)) {
$sql .= " AND default_vat_code='" . $vat_src_code."'";
$sql .= ' AND default_vat_code="' . $db->escape($vat_src_code).'"';
}


$resq = $db->query($sql);
if (!$resq) {
print json_encode(array('retour' => 0, 'error' => $db->lasterror()));
return;
}

if($resq->num_rows !== 0){ // s'il existe, on renvoie l'id de cet ligne prix
$obj = $db->fetch_object($resq);
Expand Down