Skip to content

Conversation

@Eleven1Liu
Copy link
Contributor

@Eleven1Liu Eleven1Liu commented May 13, 2023

What does this PR do?

  • Allow setting no_merge_train_val in the configuration file.
  • Issue: search_params.py only takes the value from arg parse. We cannot disable retrain from *_tune.yml.
# hyperparamter search
search_alg: basic_variant
embed_cache_dir: null
num_samples: 1
scheduler: null
no_merge_train_val: true # not work

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Eleven1Liu Eleven1Liu changed the title args.no_merge_train_val -> config.no_merge_train_val Set no_merge_train_val in *_tune.yml May 13, 2023
Gordon119
Gordon119 previously approved these changes May 15, 2023
@Eleven1Liu Eleven1Liu merged commit 2f108e1 into ASUS-AICS:master May 15, 2023
@Eleven1Liu Eleven1Liu deleted the retrain_args branch May 15, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants