Skip to content

Conversation

@DanielKristofKiss
Copy link
Contributor

SHF_AARCH64_PURECODE section flag to indicate a given section doesn't contain data similarly to the SHF_ARM_PURECODE flag.

@DanielKristofKiss
Copy link
Contributor Author

cc: @stuij @smithp35 @walkerkd

@DanielKristofKiss
Copy link
Contributor Author

cc: @mmalcomson

Copy link
Contributor

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. With review comment addressed this matches the definition in the 32-bit ABI.

Apologies for the delay in responding, just come back from vacation.

@stuij stuij requested a review from sallyarmneale January 7, 2025 09:30
@smithp35
Copy link
Contributor

smithp35 commented Feb 4, 2025

@DanielKristofKiss would you like me to merge this for you?

@DanielKristofKiss
Copy link
Contributor Author

@smithp35 Yes please!

@smithp35 smithp35 merged commit 11f628a into ARM-software:main Feb 4, 2025
1 check passed
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Feb 4, 2025
…g (2/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Simlarly to ARM targets, generating object files with the
`SHF_AARCH64_PURECODE` flag set is enabled by the
`-mexecute-only`/`-mpure-code` driver flag.
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Feb 4, 2025
…flag (3/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.
jh7370 pushed a commit to llvm/llvm-project that referenced this pull request Feb 14, 2025
…#125687)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Generating object files with the `SHF_AARCH64_PURECODE` flag set is
enabled by the `+execute-only` target feature.

Related PRs:
* Clang: #125688
* LLD: #125689
github-actions bot pushed a commit to arm/arm-toolchain that referenced this pull request Feb 14, 2025
… flag (1/3) (#125687)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Generating object files with the `SHF_AARCH64_PURECODE` flag set is
enabled by the `+execute-only` target feature.

Related PRs:
* Clang: llvm/llvm-project#125688
* LLD: llvm/llvm-project#125689
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Feb 14, 2025
…g (2/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Simlarly to ARM targets, generating object files with the
`SHF_AARCH64_PURECODE` flag set is enabled by the
`-mexecute-only`/`-mpure-code` driver flag.
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Feb 14, 2025
…flag (3/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this pull request Feb 14, 2025
…llvm#125687)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Generating object files with the `SHF_AARCH64_PURECODE` flag set is
enabled by the `+execute-only` target feature.

Related PRs:
* Clang: llvm#125688
* LLD: llvm#125689
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Feb 18, 2025
…flag (3/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Feb 19, 2025
…flag (3/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.
MaskRay pushed a commit to Il-Capitano/llvm-project that referenced this pull request Feb 20, 2025
…flag (3/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.
MaskRay pushed a commit to llvm/llvm-project that referenced this pull request Feb 21, 2025
…flag (3/3) (#125689)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.

Related PRs:
* LLVM: #125687
* Clang: #125688
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Feb 21, 2025
…LF section flag (3/3) (#125689)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets. The
output section only has the `SHF_AARCH64_PURECODE` flag set if all input
sections have it set.

Related PRs:
* LLVM: llvm/llvm-project#125687
* Clang: llvm/llvm-project#125688
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this pull request Feb 24, 2025
…llvm#125687)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Generating object files with the `SHF_AARCH64_PURECODE` flag set is
enabled by the `+execute-only` target feature.

Related PRs:
* Clang: llvm#125688
* LLD: llvm#125689
Il-Capitano added a commit to Il-Capitano/llvm-project that referenced this pull request Mar 3, 2025
…g (2/3)

Add support for the new SHF_AARCH64_PURECODE ELF section flag: ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Simlarly to ARM targets, generating object files with the
`SHF_AARCH64_PURECODE` flag set is enabled by the
`-mexecute-only`/`-mpure-code` driver flag.
davemgreen pushed a commit to llvm/llvm-project that referenced this pull request Mar 10, 2025
…g (2/3) (#125688)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Simlarly to ARM targets, generating object files with the
`SHF_AARCH64_PURECODE` flag set is enabled by the
`-mexecute-only`/`-mpure-code` driver flag.

Related PRs:
* LLVM: #125687
* LLD: #125689
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Mar 10, 2025
…section flag (2/3) (#125688)

Add support for the new SHF_AARCH64_PURECODE ELF section flag:
ARM-software/abi-aa#304

The general implementation follows the existing one for ARM targets.
Simlarly to ARM targets, generating object files with the
`SHF_AARCH64_PURECODE` flag set is enabled by the
`-mexecute-only`/`-mpure-code` driver flag.

Related PRs:
* LLVM: llvm/llvm-project#125687
* LLD: llvm/llvm-project#125689
Copy link

@sallyarmneale sallyarmneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants