Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Apr 9, 2023

Updating before merging in larger changes.

@ax3l
Copy link
Member Author

ax3l commented Apr 9, 2023

@atmyers @WeiqunZhang related to the change in AMReX-Codes/amrex#3243 (I think), I see a regression in pyAMReX with Ubuntu / [email protected]:

../../../tests/test_geometry.py::test_probDomain MPI initialized with 1 MPI processes
MPI initialized with thread support level 3
AMReX (23.04-17-g8cae8024915f) initialized
terminate called after throwing an instance of 'std::runtime_error'
  what():  Assertion `iters < 20' failed, file "/home/runner/work/pyamrex/pyamrex/build/_deps/fetchedamrex-src/Src/Base/AMReX_Geometry.cpp", line 558

This is the test:

@pytest.mark.skipif(amrex.Config.spacedim != 3, reason="Requires AMREX_SPACEDIM = 3")
def test_probDomain(box, real_box):
gm = Gm()
coord = 1
is_periodic = [0, 0, 1]
gm.define(box, real_box, coord, is_periodic)
assert gm.ok()
lo = [0, -1, 1]
hi = [1, 0, 2]
rb = amrex.RealBox(lo, hi)
gm.ProbDomain(rb)
assert (
np.isclose(gm.ProbLo(0), lo[0])
and np.isclose(gm.ProbLo(1), lo[1])
and np.isclose(gm.ProbLo(2), lo[2])
and np.isclose(gm.ProbHi(0), hi[0])
and np.isclose(gm.ProbHi(1), hi[1])
and np.isclose(gm.ProbHi(2), hi[2])
)

Did something change in the logic that we need to reflect here, too?

@ax3l ax3l requested review from WeiqunZhang and atmyers April 9, 2023 20:07
@ax3l ax3l added the help wanted Extra attention is needed label Apr 9, 2023
@ax3l ax3l mentioned this pull request Apr 9, 2023
3 tasks
@WeiqunZhang
Copy link
Member

AMReX-Codes/amrex#3247

@ax3l
Copy link
Member Author

ax3l commented Apr 10, 2023

Thanks a lot!
Tested with the above PR to AMReX: tests are passing ✔️

@ax3l ax3l merged commit 469858e into AMReX-Codes:development Apr 11, 2023
@ax3l ax3l deleted the amrex-weekly branch April 11, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants