-
Notifications
You must be signed in to change notification settings - Fork 427
Support SoA-Only Particles #2878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
atmyers
merged 123 commits into
AMReX-Codes:development
from
Thierry992:particle_soa_refactor
Apr 17, 2023
Merged
Changes from all commits
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
dc0e7c1
Begin refactor of particle classes to allow positions and ids in SoA …
atmyers 95357fa
do not redefine default arguments
atmyers 9900521
Sprint: Add New Tile Interfaces
Thierry992 27cf58d
Last functions added to the Soa Particle struct
Thierry992 b750561
main file
Thierry992 0fc0c4a
Adding particle type corrections
Thierry992 56d6297
Adding particle type corrections
Thierry992 bb0f1c9
Adding correction to the cpu function
Thierry992 1fcfc22
test git push
Thierry992 528a67d
Merge branch 'thierry_soa_particle' of https://github.com/Thierry992/…
Thierry992 eba049f
Correcting the "!" and switching id/cpu index
Thierry992 ba3e58e
Still correcting Type errors
Thierry992 8b0daaf
fixing some compile errors, some still remain.
atmyers 9221328
Adding new struct with N=0 output to GPU Array
Thierry992 d75a35c
Correction to a typing error
Thierry992 517970f
Compute a forward Declaration of SoAPartile class
Thierry992 158116c
Correcting the *void error
Thierry992 d03bd32
First version of the code that compiles !
Thierry992 79ab70d
Fixed test ParticleTransformation
Thierry992 7f97952
First compile with debug mode
Thierry992 6ab3e31
Correcting Particle Container Type in ParIter.H
Thierry992 bb9d53c
new main function
Thierry992 0c9aa59
Reset: `AMReX_Array.H`
ax3l 5f2cab6
Example: Fix Unused Vars
ax3l 3152370
Creating MakeParticle file to adapt to the new particle constructor
Thierry992 68d4652
Correcting ParIter.H file header
Thierry992 090e762
Forward Declarations in ParIter.H
Thierry992 1d7a48d
Add NexId function to the SoAParticle Structure
Thierry992 3ee712f
Replace the ConstParticleTileData at the top
Thierry992 52e90ae
Add rdata and idata to SoAParticle
Thierry992 6c39278
deleted one redundance getsuperparticle
Thierry992 d09f797
Write GetSuperParticle for SoAParticle
Thierry992 d5d8c1f
Fix the ReduceOp for the SoA Particle struct
Thierry992 ada7a1f
Function to get rdata and idata from ParticleTileData
Thierry992 58e7274
Adding test to SoAParticle main.cpp
Thierry992 d4388f9
Fix Particle Iterator Type & Pinned Real Vector
ax3l 80d41aa
Clean up Formatting
ax3l b237dc5
Add tmp.copyParticles
ax3l c36f149
Adding corrections and test to amrex soa particle
Thierry992 ef82e8f
new main test
Thierry992 4cc5a49
trying to correct .copyParticles for SoA
Thierry992 9accbf1
Adapting the copyParticles function to SoAParticle
Thierry992 691a93c
Adapt new features to SoAParticles
Thierry992 8516860
Adapting ParticleContainerI.H to SoA
Thierry992 5f51d4b
Rewrote numParticlesOutOfRange and add constructor to SoAParticle
Thierry992 e9c91e5
Create a ConstSoAParticle class
Thierry992 db5b1f4
Adding ConstSoAParticle
Thierry992 9a47bfa
Still have to solve the enable_if error message
Thierry992 972095c
Adapating ParticleContainerI.H file to SoA
Thierry992 4b67ffa
Correcting the ParticleContainerI.H file to SoA
Thierry992 8b0a527
Commenting memcpy part
Thierry992 7fef711
Commenting memcpy part
Thierry992 a7b7344
Not incrementing the dst pointer by 1
Thierry992 8a7038a
Not incrementing the +1 in superparticle_size
Thierry992 9b1da5c
set Particlesize to zero
Thierry992 74e05d8
fix test
atmyers 203346b
fix extraneous bracket
atmyers af5d227
Squashed commit of the following:
atmyers 4d9bf4c
Squashed commit of the following:
atmyers c036e3e
Merge branch 'development' into particle_soa_refactor
atmyers 95b053d
fix no-effect const
atmyers 226181c
fix id() and cpu() for ConstSoAParticle too
atmyers aa5e7dd
add AMReX_MakeParticle.H to Make.package and CMakeLists.txt
atmyers 1afb6f6
remove unused
atmyers a5c800f
remove unused
atmyers 703d481
Merge remote-tracking branch 'mainline/development' into particle_soa…
ax3l 6a522bf
Merge remote-tracking branch 'mainline/development' into particle_soa…
ax3l 5614975
Fix: Unused Variables/Typedefs
ax3l 04fd51b
PureSoA Test: ID Assignment
ax3l 5df2b0b
Remove EOL Whitespaces
ax3l a580f7b
[Work-Around] GPUArray & Particle Type
ax3l be35983
ParticleTileData: Remove Debug Static Assert
ax3l fb37837
Cleanup ConstType Traits
ax3l c9f1402
Fix: ConstSoAParticle is SoAParticle
ax3l a026399
ConstSOAParticle: Add Missing Forward Declaration
ax3l 0fc9623
Constructor Cosmetics
ax3l 0187ac9
remove restrict from these members of ConstParticleTileData
atmyers e4a8f0e
fix applying periodic shift to the particle send buffer
atmyers df1a2e9
Merge branch 'particle_soa_refactor' of github.com:Thierry992/amrex i…
atmyers 1c6134f
ParticleTile: Fix Const Access
ax3l 2c4a6e5
remove now unused type alias
atmyers d286e8b
fix out of bounds access
atmyers c044a29
also constexpr when unpacking on CPU for GPU runs
atmyers df3d866
fix warnings
atmyers 6bb4b0e
fix make_particle for legacy particle type
atmyers b72780e
some host / device annotations
atmyers 99b49d2
More Host-Device
ax3l 09acfd0
add missing include guard
atmyers 5d1e9fd
some make_particle in ParticleUtil.H
atmyers b37fe61
remove old assert and add constexpr if
atmyers 807ab00
Merge branch 'particle_soa_refactor' of github.com:Thierry992/amrex i…
atmyers 49f672c
Cleaning
ax3l 5af2224
SOAParticle: 1D and 2D Support
ax3l 3bd8972
ParticleTile: Const Ptr Interfaces
ax3l f2bdf6f
SOAParticlTest: Improve & Clean
ax3l 602a081
fix a couple of redistribute bugs
atmyers d501811
Merge branch 'particle_soa_refactor' of github.com:Thierry992/amrex i…
atmyers aa244d9
fix CPU redistribute with pure SOA particles
atmyers da0c032
Merge remote-tracking branch 'mainline/development' into particle_soa…
ax3l 610c130
fix up RedistributeGPU for SOA particles
atmyers 5599501
merging
atmyers 1047e01
fix bad merge
atmyers 867f298
remove unused
atmyers 6f0e1c0
removed unused typedef
atmyers 00ebbd9
use auto
atmyers cc9880b
use auto*
atmyers 07d73cd
test did not have enough components for what it's doing
atmyers e3fd907
merging with development
atmyers c4f92eb
make the return type of MakeParticle const
atmyers 0576ec1
pass by const&
atmyers c96cbd8
handle different id numbers in RedistributeMPI
atmyers b8c7acf
auto const
atmyers acaf3a4
remove auto const
atmyers 94a5ada
Compiler Warnings: Const & Narrowing ID
ax3l 8c91aef
More Narrorwing Conversions
ax3l 0d8bf58
modernize loop as per linter
ax3l 57a66d7
Destructor: override -> virtual
ax3l 34326a5
Revert last change in destructor
ax3l 3d2c49f
Re-add NOLINT
ax3l 00c28c8
RedistributeSOA/main.cpp more clang-tidy
ax3l 4617137
2x modernize-auto
ax3l adc1db9
Avoid copy
ax3l 6afa7f6
Merge remote-tracking branch 'mainline/development' into particle_soa…
ax3l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -897,3 +897,4 @@ namespace amrex | |
| } | ||
|
|
||
| #endif | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.