Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 23 23
Lines 2687 2687
=======================================
Hits 2674 2674
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables prek to run alongside pre-commit
Codespell config:
Updated .pre-commit-config.yaml to pass --toml pyproject.toml to codespell (with tomli dependency), replacing the inline exclude regex. Added skip = ".svg,.ipynb" to [tool.codespell] in pyproject.toml to preserve the same exclusions.
JSON fixes: Replaced 11 bare Infinity values with null across docs/source/attacks/report_example_worstcase.json (10) and report_example_lira.json (1). Aligns with #421 (task I completed prior).
Why pre-commit didn't catch the JSON issue:
Python's json.loads() accepts bare Infinity, -Infinity, and NaN as non-standard extensions. The check-json hook from pre-commit-hooks uses json.loads(), so it silently passes invalid JSON values. prek uses a stricter JSON parser that follows the spec.
Closes #434
@rpreen