Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 9 9
Lines 1354 1354
=======================================
Hits 1350 1350
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable 11 previously-disabled ruff rule sets via config-only changes to
pyproject.toml. No Python source files were modified.Enabled rule sets
C4, DTZ, E, EM, PD, PLR, PLW, RET, S, SIM, T20
Left disabled
ERA - 42 violations across tests, notebooks, and source files. Better suited as a dedicated cleanup PR.
Strategy
max-args = 12,max-returns = 10Future refactoring candidates
Per-file-ignores that could be removed after dedicated cleanup PRs:
acro/acro_tables.py- PLR0913, PLR1714, SIM102, SIM108, PLW2901, EM, PD002, PD011, PD101acro/acro_stata_parser.py- C417, PLR5501, T20acro/record.py- DTZ005, EM, PLW2901, T20acro/acro.py- SIM113acro/utils.py- PD002@rpreen
Closes #348