Skip to content

Conversation

@Stephen02Zhang
Copy link
Contributor

closes #3400

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #3402 (5b3fb96) into release/1.4.0 (841eedc) will increase coverage by 0.40%.
The diff coverage is 27.27%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/1.4.0    #3402      +/-   ##
=================================================
+ Coverage          90.19%   90.60%   +0.40%     
=================================================
  Files                651      653       +2     
  Lines              24324    24356      +32     
  Branches            2137     2142       +5     
=================================================
+ Hits               21939    22067     +128     
+ Misses              2280     2184      -96     
  Partials             105      105              
Impacted Files Coverage Δ
....Core/Network/Events/StreamMessageReceivedEvent.cs 0.00% <0.00%> (ø)
...OS.Core/Network/Events/StreamPeerExceptionEvent.cs 0.00% <0.00%> (ø)
src/AElf.OS.Network.Grpc/Connection/PeerDialer.cs 94.11% <ø> (-1.13%) ⬇️
src/AElf.OS.Network.Grpc/Peer/GrpcPeer.cs 87.57% <ø> (+3.10%) ⬆️
.../AElf.OS.Network.Grpc/Service/GrpcServerService.cs 100.00% <ø> (ø)
src/AElf.OS.Network.Grpc/Service/IStreamService.cs 42.10% <ø> (+18.42%) ⬆️
...dlers/Network/StreamMessageReceivedEventHandler.cs 0.00% <0.00%> (ø)
...andlers/Network/StreamPeerExceptionEventHandler.cs 0.00% <0.00%> (ø)
src/AElf.OS.Network.Grpc/Peer/GrpcStreamPeer.cs 45.67% <18.75%> (+45.67%) ⬆️
src/AElf.OS.Network.Grpc/Helpers/CommonHelper.cs 92.30% <80.00%> (+54.80%) ⬆️
... and 3 more

... and 2 files with indirect coverage changes

@Stephen02Zhang Stephen02Zhang changed the title Feature/new stable stream improve grpc stream stability and performance Jun 14, 2023
@jason-aelf jason-aelf merged commit c0f24b9 into release/1.4.0 Jun 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/new-stable-stream branch June 14, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants