This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Add mobile push notifications using WebPush#49
Merged
Conversation
…o publicly host it unless it becomes irrational in cost which should never happen)
…g the user of them)
… (for token auth atm)
…rmine which should be used
…gisters/deregisters always go off this way)
…notification isn't enabled
currenttly all browser requrire a `push` produces a notification, if not, push subscription may be revoked. see: firebase/firebase-js-sdk#8010 (comment) in this case, sygnal, the push gateway will send unread count, and create a `push` event, when messages are read on other clients. Therefore we have no choice but to stop sygnal from pushing data that won't be presented as notifications see: https://github.com/element-hq/sygnal/blob/da48ba7457409391c1d12140ce2ea3d49d377ff3/sygnal/webpushpushkin.py#L142-L145
so that a notification will always be generated from a push event, avoiding being killed for privacy policies from browser and os
Sygnal already adds `mailto:` by itself. When added manually, apple will error out with `403: BadJwtToken`. Hence the mailto should be removed :) (cherry picked from commit 0d66762) Signed-off-by: Kris Hu <i@krishu.moe>
Pull upstream changes before creating PR to upstream
This reverts commit 86a3906.
…correct session before opening room on click
Collaborator
Author
|
This should now correctly handle the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mobile push notifications via web push, default config uses a Sygnal server hosted by @GigiaJ at the moment. This can easily be swapped out via the instructions and config originally provided by him.
Description
Fixes #44
Type of change
Checklist:
~ Evie