This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Change profile pronouns to closer follow MSC4247#33
Merged
Conversation
Fixes #23 The pronouns field is an array of pronoun sets rather than the entire array representing one set. This follows MSC4247, and aligns with the way it's displayed in gomuks and Commet. For compatibility with gomuks, the value of `language` for each is set to "en". In the future this should be set manually or use the client language. Pronoun summaries are limited to 16 characters each, and truncated to that length if it is longer. When displayed as a string, or when it is set, they are comma separated. When they are displayed next to the username in a message, they're each in an individual pill, only showing the first 3. If more than 3 are there, an extra pill showing "..." is displayed. An optional `grammatical_gender` field now exists, however it is currently unused.
Author
Owner
|
I think it's better to cut into the username a little. The pronoun pills can always be disabled in settings for anyone who doesn't want that and I think most users don't have long enough names where this would matter (i.e. most names that long are multiple words, where users also just go by a shorter nickname). |
Author
7w1
approved these changes
Feb 28, 2026
Owner
7w1
left a comment
There was a problem hiding this comment.
Looks good! Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The pronouns field is an array of pronoun sets rather than the entire array representing one set. This follows MSC4247, and aligns with the way it's displayed in gomuks and Commet.
For compatibility with gomuks, the value of
languagefor each is set to "en". In the future this should be set manually or use the client language.Pronoun summaries are limited to 16 characters each, and truncated to that length if it is longer. When displayed as a string, or when it is set, they are comma separated. When they are displayed next to the username in a message, they're each in an individual pill, only showing the first 3. If more than 3 are there, an extra pill showing "..." is displayed.
An optional
grammatical_genderfield now exists, however it is currently unused.Fixes #23
Type of change
Users would have to re-set their pronouns to display correctly
Checklist:
The changes are simple and self explanatory, and documentation appears to not exist