This repository was archived by the owner on Mar 10, 2026. It is now read-only.
Add a counter for unread pins and highlight unread pins in pin menu.#31
Merged
Add a counter for unread pins and highlight unread pins in pin menu.#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the pin counter with the number of unread pins and added a subtle outline to unread messages in the pin list.
Closes #25 using the described implementation until MSC4238 is discussed further/merged.
Stores the following to room account data under the key
moe.sable.app.pins_read_marker{ "hash": "a3f9b2c1d4", "count": 7, "last_seen_id": "$abc123" }If the last seen ID is unpinned, it relies on the count to determine which pins to highlight/number to show, subtracting one from the stored count (because that last seen message was unpinned), and then continues to render the number/highlight based on that. This method DOES NOT work when the last seen pin was unpinned in addition to other pins, and will result in any additional pins less than the unpinned pins count being missed.
I unfortunately do not see any way around that issue without keeping track of every single pin message id, which I'd like to avoid.
Type of change
Checklist: