This repository was archived by the owner on Mar 10, 2026. It is now read-only.
fix: notification delivery, account switching, and unread count toggle#127
Merged
fix: notification delivery, account switching, and unread count toggle#127
Conversation
Just-Insane
force-pushed
the
fix/notification-delivery
branch
2 times, most recently
from
1ae7328 to
1bb85f2
Compare
added 3 commits
March 4, 2026 22:24
…witching - HandleNotificationClick moved outside ClientRoot loading gate so SW postMessages are never dropped during account-switch reloads - iOS Safari event.source=null guard removed; type-check used instead - ToRoomEvent simplified: writes pendingNotificationAtom + sets active session, delegates navigation to NotificationJumper - NotificationJumper: jumpingRef prevents repeated navigation; stable performJumpRef avoids re-registering listeners on every atom change during account switch - BackgroundNotifications: uses SW showNotification for reliable tap routing on iOS; dedupeId is now userId+eventId scoped; visibility guard prevents backgrounded in-app popups; ref pattern avoids stale closure on settings - SW: persist/restore notification settings across iOS SW restarts via Cache API; group notifications by room (tag + renotify); prefer navigate() over postMessage when available; prefer visible tab on notificationclick - pushNotification: resolveSilent respects tweaks.sound; recipientId in title; fallbackNotification removed (redundant) - RoomTimeline: use ref for handleOpenEvent to stop re-pulling on every new message
…highlight badges - getUnreadInfo: guard stale-count clamp with roomHaveUnread; exclude own messages from clamp trigger; walk live timeline to compute real fallback counts using PushProcessor instead of hard-coding dot badge - roomToUnreadAtom: remove mDirectAtom dependency for DM parent filtering; add ClientEvent.Room handler to seed badge state when rooms join - sessionsHighlightAtom added to track highlight counts per inactive session - AccountSwitcherTab: show UnreadBadge on inactive session rows and sidebar icon
Hides numeric counts on room and sidebar badges while keeping the dot indicator active. Defaults to on. Exposed in both Appearance and Cosmetics settings panels.
Just-Insane
force-pushed
the
fix/notification-delivery
branch
from
1bb85f2 to
3a4961e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several notification issues, primarily on iOS, and adds a new appearance setting.
Notification fixes
event.source = nullbehaviour no longer silently drops SW postMessagespostMessagefor open clients andopenWindowonly when the app is closedNew setting