fix: stream array-root JSON extraction#2308
Open
pragnyanramtha wants to merge 2 commits into
Open
Conversation
…rray-root # Conflicts: # instructor/utils/core.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes the streaming JSON extractor so markdown/plain streaming responses whose root JSON value is an array are preserved as arrays instead of starting at the first object inside the array. The sync and async extractors now track both object and array delimiters while preserving the existing string/escape handling.
Added regression coverage for chunked markdown JSON streams with array roots in both sync and async paths.
Issue ticket number and link
N/A
Validation
uv run --extra dev pytest tests/test_utils.py tests/test_json_extraction.py tests/test_json_extraction_edge_cases.py tests/dsl/test_gemini_tools_async_streaming.py -q-> 63 passed, 2 skippeduv run ruff format --check instructor/utils/core.py tests/test_utils.py-> passeduv run ruff check instructor/utils/core.py tests/test_utils.py-> passedgit diff --check-> passedChecklist before requesting a review