fix(validation): require is_valid in Validator#2230
Merged
jxnl merged 1 commit into567-labs:mainfrom Mar 28, 2026
Merged
Conversation
This was referenced Mar 28, 2026
conjon42
pushed a commit
to conjon42/instructor
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2225
Summary
This PR makes
Validator.is_validrequired instead of relying on a default value.What Changed
Truevalue fromValidator.is_validreasonrequired as wellWhy
The issue describes a fail-open case where partial validator output like:
{"reason": "value violates the rule"}can be interpreted as valid because
is_validfalls back to a default.Rather than changing the fallback behavior, this PR enforces the expected schema so responses that omit
is_validfail validation instead of being treated as valid.Issue: #2225